Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suffixing field names in auto completion with colon (':'). (Backport of #7489 for 3.2) #7493

Merged
merged 1 commit into from Feb 18, 2020

Conversation

linuspahl
Copy link
Contributor

@linuspahl linuspahl commented Feb 18, 2020

Backport of #7489 for 3.2

Description

Motivation and Context

The legacy search suffixed field names in the query input's
auto-completion with a colon, as most users would want to write a value
next, after completing the field name. The new search does not do this
yet.

This change is suffixing all field names suggested for field completion
with a colon.

Fixes #7408.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

* Suffixing field names with colon.

* Adding test cases.
@dennisoelkers dennisoelkers merged commit f6251bf into 3.2 Feb 18, 2020
@dennisoelkers dennisoelkers deleted the issue-7408-backport-3.2 branch February 18, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants