Work around non-existing Event constructor in IE11.
#7951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Internet Explorer 11, calling `new Event()` raises an exception. Instead, a new event needs to be created using `el.createEvent`/`event.initEvent`, the latter being deprecated on all other major browsers. This PR is abstracting the uglyness of this circumstance by offering a `createEvent` function which returns an event after checking if the `Event` constructor is available, using the other approach if not. Fixes #7670.
dennisoelkers
force-pushed
the
issue-7670
branch
from
f377c52
to
bb6735e
Compare
linuspahl
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
In Internet Explorer 11, calling
new Event()raises an exception.Instead, a new event needs to be created using
el.createEvent/event.initEvent, the latter being deprecated on allother major browsers.
This PR is abstracting the uglyness of this circumstance by offering a
createEventfunction which returns an event after checking if theEventconstructor is available, using the other approach if not.Fixes #7670.
How Has This Been Tested?
regular approach.
Screenshots (if appropriate):
Types of changes
Checklist: