-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev 1.1.0 #25
Merged
LiRogers
merged 43 commits into
Greater-London-Authority:master
from
LiRogers:dev_1.1.0
Aug 26, 2020
Merged
Dev 1.1.0 #25
LiRogers
merged 43 commits into
Greater-London-Authority:master
from
LiRogers:dev_1.1.0
Aug 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggplot2 3.3.0 includes theme attributes to do this. These have been added to gla_theme
And roxygen version
expand_scale -> expansion
Changes to margins to allow titles, subtitles and y text to fit. Shift y axis labels to sit on axis ticks
Donuts and Horizbars shouldn't have them, so add call to theme to remove ggla_axisat0 needs the axis tick at 0 to be the same colour, adjust theme call to have strong_grid for first line, and light grid for rest
Add option for setting y_label_length
Add panel spacing for faceting
Basic plotly functionality
New vignette explaining how to use gglaplotly
Few small changes
This shouldn't have been commited
And note in vignette
Mean functions can be applied to base plotly figures as well as ggplots converted to plotly
ggplotly can now be used with ggla_line
Change from gglaplotly to settings function
Adjust facet settings
Add faceting examples and make changes need following changes to theme_gla
last_plot is in both ggplot2 and plotly and was causing a conflict
Move elipses into previous plotly::style call, was causing an error if no further args were given
Bump version
Adjust size of plots
Add new functions and vignettes to pkgdown
Correct headings
With adjusted headers
Update ROxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes relate to new functionality in ggplot2 3.3 and new functions to apply gglaplot style to plotly plots. The package now depends on ggplot2 v3.3.
New features
%>%
it intoggla_plotly_settings()
. This adjust the plotlylayout
,style
andconfig
settings. Each of these can applied seperately (and adjusted with addtional arguments) withggla_plotly_layout()
,ggla_plotly_style()
andggla_plotly_config()
. (closes Link to plotly #23)Major changes
left_align_labs()
is being deprecated. The functionality to fully left align titles, subtitles and captions is now included intheme_gla()
. Left aligning the legend is an open issue in ggplot2 which will be resolved in v3.4.y_label_length
intheme_gla()
. (closes Long y-axis labels mess up alignment #21)theme_gla()
now includes a boolean arguementfree_y_facets
. This should be used for faceted plots with free scales on the y axis. This changes the position of the y-axis labelsBug fixes