Update Input and InputWrapper #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamesscottbrown I just realized I need to update other components using the |
@jamesscottbrown Good to review now. |
|
This looks ok - I'll add some docs then merge. |
jamesscottbrown
added a commit
that referenced
this pull request
May 13, 2024
* Increase text size on tooltips (#299) * Storybook component descriptions (#300) * Move component descriptions so they display on autodocs generated page * move component descriptions to JSDocs * set props for default story * fix storybook controls so that they update component in default stories (#298) * fix storybook controls so that they update component in default stories * constrain tab orientation control to permitted values * Update Checkbox & CheckboxGroup with tooltips (#296) * Align text and icon in tooltip trigger (#306) * align text and icon in tooltip trigger * add changeset file * separate out stories for CheckboxGroup and RadioButtonGroup (#310) * align contents of MapControlGroup depending on position (#302) * fix formatting of markdown table in docs (#308) * fix formatting of markdown table in docs See storybookjs/storybook#22613 (comment) * re-format with prettier * Improve docs (#312) * Adds name prop to checkbox and checkbox group options (#313) * Adds PageMetadata component (#307) --------- Co-authored-by: James Scott-Brown <James.Scott-Brown@london.gov.uk> * replace use of deprecated <Meta> tag in stories (#315) * Update Input and InputWrapper (#311) --------- Co-authored-by: James Scott-Brown <James.Scott-Brown@london.gov.uk> * Add placeholder image component (#319) --------- Co-authored-by: James Scott-Brown <James.Scott-Brown@london.gov.uk> * fix import of PlaceholderImage * Add analytics and cookie consent component (#317) --------- Co-authored-by: James Scott-Brown <James.Scott-Brown@london.gov.uk> * Add a CopyButton component (#321) --------- Co-authored-by: James Scott-Brown <James.Scott-Brown@london.gov.uk> * [docs] add docs for Select component (#320) * modify Geocoder doc strings (#322) mostly fixing multi-line comments, and making some minor edits * [docs] make toaster docs more like that of other components (#323) * [docs] add more docs for Header components (#325) * Fix missing key in checkboxgroup each block (#324) * [docs] Add some docs for the AppShell (#326) * [docs] add docs for sidebar (#327) --------- Co-authored-by: Paul Williams <paul.williams@london.gov.uk> * auto-format with prettier * add some docs for color legend component (#329) --------- Co-authored-by: Paul Williams <paul.williams@london.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates:
Inputto allow textarea type.Inputto pass$$restPropsto the input element to account for differences in properties for different input types.Inputto export the bindable input element value.Inputto allow a format value function to be passed that formats the value when unfocusing the input.InputWrapperto allow tooltip hints in the label.InputandInputWrapperwith aria and accessibility attributes.Why?
So the input is usable and accessible with HTML forms and multiple input types.
How is it tested?
Storybook
How is it documented?
Stroybook
Is it complete?