Remove JSON examples from artifacts #450
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
#440
Summary
Remove data source and location source JSONs from artifacts.
These JSONs are no longer provided from both CLI and WebAPI includes container image, but we can use them of course if we need because JSONs are still kept in the repo.
Changes
Essense of this PR is following:
data-sources/
fromItemGroup
, anddata-sources/json
would be created in publish directory.location-sources/
fromItemGroup
, andlocation-sources/json
would be created in publish directory.test-data-azure-emissions.json
is no longer set by default.dotnet tool run
for generating OpenAPI document.data-sources
andlocation-sources
.data-sources
andlocation-sources
, but they would be created into publish directory.This PR has other changes, but they are for test cases because they depends JSON data source and location source.
Note that I commented out test case for ElectricityMapsFree in both src/CarbonAware.WebApi/test/integrationTests/CarbonAwareControllerTests.cs and src/CarbonAware.WebApi/test/integrationTests/LocationsControllerTests.cs because IntegrationTestingBase.cs does not have configuration for ElectricityMapsFree. I will fix it after this PR.
Checklist
Are there API Changes?
No
Is this a breaking change?
This PR breaks current behavior. CASDK is no longer refer test-data-azure-emissions.json for data source and azure-regions.json for location source. CASDK requires the user to configure data source at least.