Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCI-m] Incorrect error when resources-total param is missing #716

Open
MariamKhalatova opened this issue May 16, 2024 · 0 comments
Open
Labels
bug Error, flaw or fault good-first-issue This issue is a good one for someone looking to get involved with this project/initiative.

Comments

@MariamKhalatova
Copy link
Contributor

MariamKhalatova commented May 16, 2024

Description of the Error

When resources-total param is missing from inputs and defaults, incorrect error message is received

Expected Behaviour

Error message should be the following:
"resources-total" parameter is required.
Error code: invalid_union.

Actual Behaviour

Received the following error
"vcpus-allocated" parameter is required. Error code: invalid_union.

Steps to Reproduce

  1. Run the manifest file (described below) , which includes sci-m plugin without resources-total param in inputs and defaults.

Manifest File That Generated the Error

name: sci-m
description: successful path
tags:
initialize:
  #outputs: ['yaml']
  plugins:
    "sci-m": # a model that calculates m from te, tir, el, rr and rtor
      method: SciM
      verbose: false
      path: "@grnsft/if-plugins"
tree:
  children:
    child:
      pipeline:
        - sci-m # duration & config -> embodied
      defaults:
        device/emissions-embodied: 1533.120 # gCO2eq
        time-reserved: 3600 # 1hr in seconds
        device/expected-lifespan: 94608000 # 3 years in seconds
        resources-reserved: 1
       # resources-total: 8
      inputs:
        - timestamp: 2023-07-06T00:00
          duration: 3600 

Runtime Info

if-version: v0.3.2
os: macOS
os-version: '13.2'
node-version: 18.14.2
@MariamKhalatova MariamKhalatova added the bug Error, flaw or fault label May 16, 2024
@zanete zanete added good-first-issue This issue is a good one for someone looking to get involved with this project/initiative. and removed help-wanted labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error, flaw or fault good-first-issue This issue is a good one for someone looking to get involved with this project/initiative.
Projects
Status: No status
Development

No branches or pull requests

4 participants