lib: simplify supercomputer calculation logic #381
Conversation
Signed-off-by: Dima Demakov <d.demakov@gmail.com>
| * Otherwise enriches inputs, passes them to Observatory. | ||
| * For each model from pipeline Observatory gathers inputs. Then results are stored. | ||
| */ | ||
| private async calculateOutputsForChild( | ||
| childrenObject: Children, | ||
| params: any | ||
| childName: string |
There was a problem hiding this comment.
Since we dropped areChildrenNested, the second object param was replaced with a string childName
| @@ -25,7 +25,7 @@ export type Children = { | |||
| pipeline: string[]; | |||
| config: Config; | |||
| inputs: ModelParams[]; | |||
| children: Children; | |||
| children?: Children; | |||
There was a problem hiding this comment.
We don't have children in the leaves of the children tree.
|
@jmcook1186 @narekhovhannisyan all tests passed, but could you plz double-check that I didn't miss anything around business logic? |
|
Hi @demakoff, thanks for your contribution to our project ✨ ! Currently based on Impact Framework's business goals, supercomputer implementation is going to change in the short period of time, and changes from your PR will conflict with it. Therefore it can't be merged. Thanks again for your contribution to our project. cc: @jmcook1186 |
Sure, np. Pleased that it works properly. Guys, @jmcook1186 @narekhovhannisyan is there something I can help with (which actually may be merged)? |
|
Hi @demakoff yes, there are tasks you can pick up for sure. We should make better use of labels to signal which tasks are best for community contributions. I'll add the There is also a hackathon coming up and we are putting together suggestions for things we want people to build. We're still refining the ideas to make them easier for people to pick up, but you can take a look at them on the discussion board here: https://github.com/Green-Software-Foundation/hack/discussions |
|
closing as fixed in #390 |
Types of changes
A description of the changes proposed in the Pull Request
calculateOutputsForChildmethod, which led to a number of conditions withareChildrenNested.computemethod while nested children processing logic was extracted tocomputeChildren. It allowed to unify processing of all children inside ofcalculateOutputsForChildmethod and got rid of allareChildrenNestedconditions.