Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precommit hooks and commitlint #426

Merged
merged 9 commits into from
Feb 5, 2024
Merged

Precommit hooks and commitlint #426

merged 9 commits into from
Feb 5, 2024

Conversation

narekhovhannisyan
Copy link
Member

@narekhovhannisyan narekhovhannisyan commented Feb 2, 2024

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Introduces pre-commit hooks. Runs lint, test before commit.
  • Introduces commitlint, linter for commit messages.
  • Drops unused ccf coef, makefile.

@narekhovhannisyan narekhovhannisyan linked an issue Feb 4, 2024 that may be closed by this pull request
@narekhovhannisyan narekhovhannisyan changed the title Precommit hooks Precommit hooks and commitlint Feb 4, 2024
@jmcook1186 jmcook1186 merged commit 2ac1457 into dev Feb 5, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the precommit-hooks branch February 5, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add commit lint and other rules (?) in CI
3 participants