Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sci e integration test #459

Merged
merged 9 commits into from
Feb 25, 2024
Merged

Fix sci e integration test #459

merged 9 commits into from
Feb 25, 2024

Conversation

MariamKhalatova
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Introduces working integration tests after functional refactoring.

@narekhovhannisyan
Copy link
Member

@MariamKhalatova please check https://if.greensoftware.foundation/contributions#generating-a-gpg-key for resolving DCO issues

@MariamKhalatova
style: testing DCO setup
d693146
@MariamKhalatova
revert(tests): remove redundant comment
be44e19
@MariamKhalatova
tests: rename ompl to output
b1e93d4 
DCO Remediation Commit for MariamKhalatova <mar.khalatova@gmail.com>

I, MariamKhalatova <mar.khalatova@gmail.com>, hereby add my Signed-off-by to this commit: 849bab6
I, MariamKhalatova <mar.khalatova@gmail.com>, hereby add my Signed-off-by to this commit: 379ccbe
I, MariamKhalatova <mar.khalatova@gmail.com>, hereby add my Signed-off-by to this commit: c9d3122
I, MariamKhalatova <mar.khalatova@gmail.com>, hereby add my Signed-off-by to this commit: 8d4b14e

Signed-off-by: MariamKhalatova <mar.khalatova@gmail.com>
@MariamKhalatova
test: rename impl to manifest in integration
f27eac2
@MariamKhalatova
test(integration): add timeout to sci-e scenario
da17373
@jmcook1186 jmcook1186 merged commit 6ac549e into functional-architecture Feb 25, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the fix-sci-e-integration-test branch February 25, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan Awaiting requested review from narekhovhannisyan

@manushak manushak Awaiting requested review from manushak

Assignees
No one assigned
Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MariamKhalatova @narekhovhannisyan @jmcook1186