Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI parameters #472

Merged
merged 18 commits into from
Feb 28, 2024
Merged

CLI parameters #472

merged 18 commits into from
Feb 28, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • CLI/Manifest parameters support

@narekhovhannisyan
revert(util): drop support for param selectors
2c887d5
@narekhovhannisyan
fix(util): import * as winston
2abaf10
@narekhovhannisyan
feat(util): implement json reader
49763d4
@narekhovhannisyan
feat(util): implement aggregation helper
e49ce84
@narekhovhannisyan
fix(types): drop support for unused cli flags
b41b5eb
@narekhovhannisyan
fix(types): fix access for parameters
d206cb8
@narekhovhannisyan
refactor(types): in manifest rename manifest common to context
551b0c3
@narekhovhannisyan
feat(types): add parameters to load
97a9b5c
@narekhovhannisyan
revert(types): drop helpers
e24c80e
@narekhovhannisyan
feat(types): add ComputeParams to compute
855ae60
@narekhovhannisyan
fix(models): use aggregation method from parameterize
becb2aa
@narekhovhannisyan
feat(lib): implement parameterize
3ae74e7
@narekhovhannisyan
feat(lib): inject parameters strategy into load
ce51b25
@narekhovhannisyan
refactor(lib): simplify compute
d46ca50
@narekhovhannisyan
refactor(lib): move aggregation function to utils
cc0d152
@narekhovhannisyan
feat(config): add reject override to strings
e8779f5
@narekhovhannisyan
feat(src): implement cli/manifest parameters logic
2c8720a
@narekhovhannisyan
chore(examples): inti new params test manifest
d16a23e
jmcook1186
jmcook1186 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally with:

  • test manifest with custom params
  • new params file provided on the command line (--override-params)

Both appear to work well.

Approving and merging but will open a new ticket for adding a warning message on params override.

@jmcook1186 jmcook1186 merged commit 4eb31eb into functional-architecture Feb 28, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the params branch February 28, 2024 09:15
@jmcook1186 jmcook1186 mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@narekhovhannisyan @jmcook1186