Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rimraf to build script #512

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Add rimraf to build script #512

merged 3 commits into from
Mar 8, 2024

Conversation

jmcook1186
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

rimraf allows building across OSs

@jmcook1186 jmcook1186 self-assigned this Mar 7, 2024
@jmcook1186 jmcook1186 added the bug Error, flaw or fault label Mar 7, 2024
@jmcook1186 jmcook1186 added this to the IF Sprint 8: 4/3/24 - 15/3/24 milestone Mar 7, 2024
package.json Outdated Show resolved Hide resolved
Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
package.json Outdated
@@ -15,6 +15,7 @@
"dependencies": {
"@commitlint/cli": "^18.6.0",
"@commitlint/config-conventional": "^18.6.0",
"@grnsft/if-unofficial-plugins": "^0.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcook1186 can you please remove this one too?

Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
@narekhovhannisyan narekhovhannisyan merged commit d05e7f6 into main Mar 8, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the rimraf branch March 8, 2024 13:33
alexzurbonsen pushed a commit to alexzurbonsen/if that referenced this pull request Mar 8, 2024
…Foundation/rimraf

Add rimraf to build script
alexzurbonsen pushed a commit to alexzurbonsen/if that referenced this pull request Mar 8, 2024
…Foundation/rimraf

Add rimraf to build script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error, flaw or fault
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants