Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error out unknown #844

Merged
merged 18 commits into from
Jun 18, 2024
Merged

Error out unknown #844

merged 18 commits into from
Jun 18, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Error out on unknown error and exit

@narekhovhannisyan
feat(util): introduce if-core utils and types
4e1ee62
@narekhovhannisyan
revert(types): drop common and group-by
8d1244a
@narekhovhannisyan
feat(types): introduce if-core types
9ee5885
@narekhovhannisyan
feat(lib): introduce if-core utils and types
27c7450
@narekhovhannisyan
revert(uiltins): drop local types support
fa18a5e
@narekhovhannisyan
feat(builtins): introduce if-core utils and types
89a19ee
@narekhovhannisyan
test(util): introduce if-core util and types
710b2a3
@narekhovhannisyan
test(lib): drop unused manifests
21c8d0b
@narekhovhannisyan
test(lib): introduce if-core utils and types
6709d12
@narekhovhannisyan
test(builtins): introduce if-core utils and types
ec2d8c0
@narekhovhannisyan
test(mocks): introduce if-core types
5ee388a
@narekhovhannisyan
fix(src): fix imports order in diff
b7a54a1
@narekhovhannisyan
feat(package): update if-core version
df7374a
@narekhovhannisyan
chore(config): drop unused module path from jest
1d39e6b
@narekhovhannisyan
revert(config): drop issue template message
8857737
@narekhovhannisyan
test(util): remove changed case
00f0daf
@narekhovhannisyan
feat(util): exit on unknown error
3000cc9
@narekhovhannisyan
chore(src): fetch changes from main
b8e299b
@jmcook1186 jmcook1186 merged commit 89f9095 into main Jun 18, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the error-out-unknown branch June 18, 2024 08:04
@narekhovhannisyan
Copy link
Member Author

#593

This was referenced Jun 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manushak manushak manushak approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@narekhovhannisyan @manushak @jmcook1186