Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace plugins with generics #851

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Replace plugins with generics #851

merged 5 commits into from
Jun 20, 2024

Conversation

MariamKhalatova
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Updates manifests to use builtins.

@MariamKhalatova MariamKhalatova self-assigned this Jun 20, 2024
@MariamKhalatova MariamKhalatova linked an issue Jun 20, 2024 that may be closed by this pull request
Remove deprecated plugins from all test manifests and replace with generics #751
Closed
4 tasks
jmcook1186
jmcook1186 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jmcook1186 jmcook1186 merged commit a4688fd into main Jun 20, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the replace-plugins-with-generics branch June 20, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak Awaiting requested review from manushak

Assignees

@MariamKhalatova MariamKhalatova

Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated plugins from all test manifests and replace with generics
3 participants
@MariamKhalatova @narekhovhannisyan @jmcook1186