Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in parameter overview not picked up by collab server #74

Closed
bl-young opened this issue Mar 1, 2019 · 1 comment
Closed

Changes in parameter overview not picked up by collab server #74

bl-young opened this issue Mar 1, 2019 · 1 comment
Labels
Milestone

Comments

@bl-young
Copy link

bl-young commented Mar 1, 2019

When parameters are edited in the new parameter overview feature (v1.8), these changes do not trigger an update when committing to the collaboration server. This occurs whether the change is made on a value or a formula. It appears as though the changes do not trigger an udpate to the version or "Last Change" on the process and therefore the collaboration server is not identifying anything to commit.

@msrocka msrocka added the bug label Mar 2, 2019
@msrocka msrocka added this to the v1.9.0 milestone Mar 2, 2019
@msrocka
Copy link
Member

msrocka commented Mar 20, 2019

It was even a bit more complicated than I first thought. If it is a global parameter it is fine to just update the version and lastChange fields. However, when it is a parameter in a process or LCIA method we also need to update this entity to which the parameter belongs.

Also, when a global parameter or the entity to which a parameter belongs is currently edited in another editor it should not be possible to modify that parameter from the parameter overview.

I hope this is fixed now. We will release it with the next version.

@msrocka msrocka closed this as completed Mar 20, 2019
msrocka added a commit that referenced this issue Mar 20, 2019
It was even a bit more complicated than I first thought. If it is a
global
parameter it is fine to just update the `version` and `lastChange`
fields.
However, when it is a parameter in a process or LCIA method we also need
to update the entity to which the parameter belongs.

Also, when a global parameter or the entity to which a parameter belongs
is currently edited in another editor it should not be possible to
modify
that parameter from the parameter overview.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants