Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinterest error #4

Closed
Buliwyfa opened this issue Jan 29, 2018 · 8 comments
Closed

Pinterest error #4

Buliwyfa opened this issue Jan 29, 2018 · 8 comments
Assignees
@ArchBlood
Labels
Status: confirmed Status: Depreciated Type: Bug

Comments

@Buliwyfa
Copy link

Buliwyfa commented Jan 29, 2018 •
edited

What steps will reproduce the problem?

Click on login using Pinterest
pinterest screen to allow

click on OK and error
3

What is the expected result?

login to humhub

What do you get instead?

An error

Exception – yii\authclient\InvalidResponseException
Request failed with code: 301, message: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>Redirecting...</title>
<h1>Redirecting...</h1>
<p>You should be redirected automatically to target URL: <a href="https://api.pinterest.com/v1/me/?access_token=AYGpWLY83EvmXcU16flWs2UcSo8uFQ5dQU8bLEVEqfy-H2BAdAAAAAA">https://api.pinterest.com/v1/me/?access_token=AYGpWLY83EvmXcU16flWs2UcSo8uFQ5dQU8bLEVEqfy-H2BAdAAAAAA</a>. If not click the link.

Additional info

Also, Icon on login using Pinterest missing

Q A
HumHub version 1.2.4
PHP version 7
Operating system windsows

Note: Please use the community site for any questions on customizing HumHub.

Note: Also provide the full error stacks from Administration --> Information --> Logging and errors from your browser console if possible.
@Felli
Copy link
Contributor

Felli commented Jan 30, 2018

I'm still working on refactoring a few of the oauths, but thanks for the information! 😄

@Felli
Copy link
Contributor

Felli commented Jan 30, 2018

Also to note, we use Font Awesome 5 for all our oauths now as it's updated more often and supports more brands than 4 and older.

@Felli Felli changed the title Pinstert error Pinterest error Jan 30, 2018
@Felli Felli mentioned this issue Jan 30, 2018
Open
24 tasks
@Felli
Copy link
Contributor

Felli commented Jan 30, 2018 •
edited

Could you change this line to return $this->api('v1/me', 'GET'); and see if that fixes the issue?

https://github.com/GreenMeteor/humhub-oauth/blob/master/oauth/Pinterest/Pinterest.php#L52

Felli added a commit that referenced this issue Jan 30, 2018
@Felli
WIP: Fix for #4
e6b652e 
This is a possible fix for #4
@Buliwyfa
Copy link
Author

Buliwyfa commented Feb 2, 2018

Try it and I get this error
2018-02-02_124827

@Felli
Copy link
Contributor

Felli commented Feb 2, 2018

This is because Pinterest doesn't access connection over HTTP, but over HTTPS, but I'll continue working on the oauth for the issues that I've ran into.

@Felli Felli mentioned this issue Feb 2, 2018
Closed
@Buliwyfa
Copy link
Author

Buliwyfa commented Feb 3, 2018

but test site has only https and all URL set on Pinterest are https

qqqqq

@Felli
Copy link
Contributor

Felli commented Feb 3, 2018

I'll talk with some of the other members of Green Meteor to find a fix for this, I'm also going to get into contact with Pinterest about this to see what can be done to fix this.

@Felli Felli mentioned this issue Feb 7, 2018
Merged
@Felli
Copy link
Contributor

Felli commented Feb 17, 2018

@Buliwyfa I've gotten good and bad news from the Pinterest devs;

Good

They will be looking into this issue and getting back to me if it's an issue on their end.

Bad

They're having issues with their approval system and are going to work on fixing this before looking into this issue.

So hopefully we'll get things working for me to submit this as well as a few other new Oauths into v1.3 brand of HumHub. 👍

@GreenMeteor GreenMeteor deleted a comment from github-actions bot Sep 22, 2019
@GreenMeteor GreenMeteor locked and limited conversation to collaborators Sep 22, 2019
@ArchBlood ArchBlood added the Status: Depreciate Up for discussing on depreciating oauth clients label Nov 1, 2019
@ArchBlood ArchBlood added Status: Depreciated and removed Status: Depreciate Up for discussing on depreciating oauth clients Status: On-Hold labels Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ArchBlood ArchBlood

Labels
Status: confirmed Status: Depreciated Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Felli @Buliwyfa @ArchBlood