Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed web map for mobile view #1701

Closed
dadiorchen opened this issue Aug 3, 2023 · 6 comments · Fixed by #1707
Closed

Embed web map for mobile view #1701

dadiorchen opened this issue Aug 3, 2023 · 6 comments · Fixed by #1707
Labels
good first issue Good for newcomers high-priority nextjs react released

Comments

@dadiorchen
Copy link
Collaborator

If user accesses https://map.treetracker.org/trees/1017648?embed=true with mobile, as shown below, because the parameter: embed=true we should hide the head (the banner with logo and menu icon)

image

Some hints:

  • Please read our readme for more information/guide/tutorial.
  • For design guidelines checkout our Figma design.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.
@shivm29
Copy link

shivm29 commented Aug 4, 2023

Hey @dadiorchen ! I think i can help.. Please assign this to me.

@dadiorchen
Copy link
Collaborator Author

It's yours now :)

@dadiorchen dadiorchen mentioned this issue Aug 23, 2023
Open
@dadiorchen dadiorchen mentioned this issue Aug 31, 2023
Open
@ratishjain12
Copy link
Contributor

@dadiorchen so basically you want to hide nav header section when embed = true?

@dadiorchen
Copy link
Collaborator Author

Yes! Please let me know if you need anything

@ratishjain12
Copy link
Contributor

Ok I am working on it will let you know

@ratishjain12 ratishjain12 mentioned this issue Aug 31, 2023
Merged
14 tasks
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🎉 This issue has been resolved in version 2.6.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers high-priority nextjs react released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fixed embed true ratishjain12/treetracker-web-map-client
3 participants
@dadiorchen @ratishjain12 @shivm29