Refactor other mod id handling #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALongStringOfNumbers
approved these changes
Jan 24, 2024
|
As a bonus, this rework could add checks for the various Forestry Modules and if they are enabled, so that it would be easier to solve #2328 |
serenibyss
force-pushed
the
sb-modid-cleanup
branch
from
20ddf05
to
323373d
Compare
ALongStringOfNumbers
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors isModLoaded() and getModItem() checks to a new consolidated system that should be much easier to manage and much less prone to merge conflicts, as well as a bit cleaner in code. Additionally caches mod loaded checks instead of rechecking each time