Fix recipe properties offsetting info text too much #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htmlcsjs
approved these changes
Jan 23, 2024
ALongStringOfNumbers
merged commit 9a7ac23
into
GregTechCEu:master
3 of 4 checks passed
serenibyss
pushed a commit
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Some recipe properties like the primitive property don't actually draw any information on JEI previews but still offset the next property by some amount, which causes ugly empty lines like the following:
This is taken from here.
Implementation Details
Correctly returns an info height of 0 if nothing is to be drawn for the primitive as well as the cleanroom recipe property
Outcome
Properly spaces the info text.