Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flysystem 2 support #115

Merged
merged 2 commits into from
Aug 20, 2021
Merged

feat: add flysystem 2 support #115

merged 2 commits into from
Aug 20, 2021

Conversation

vincentchalamon
Copy link
Collaborator

@vincentchalamon vincentchalamon commented Jul 22, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #113
License MIT

Backport from #114

@VincentLanglet
Copy link

Thanks, I will take a look how to fix this.

@vincentchalamon vincentchalamon marked this pull request as draft July 22, 2021 12:54
@vincentchalamon vincentchalamon removed the request for review from GregoireHebert July 22, 2021 12:54
@vincentchalamon vincentchalamon force-pushed the feat/flysystem2 branch 5 times, most recently from 732d621 to 0227704 Compare July 22, 2021 13:32
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #115 (fefc871) into main (18c185b) will decrease coverage by 4.90%.
The diff coverage is 15.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #115      +/-   ##
============================================
- Coverage     76.96%   72.05%   -4.91%     
- Complexity      220      258      +38     
============================================
  Files            36       40       +4     
  Lines          1033     1120      +87     
============================================
+ Hits            795      807      +12     
- Misses          238      313      +75     
Flag Coverage Δ
phpunit 72.05% <15.38%> (-4.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Adapter/Builder/LocalAdapterDefinitionBuilder.php 9.09% <0.00%> (-1.44%) ⬇️
src/Controller/Sign.php 94.11% <ø> (ø)
src/EnvelopeBuilder.php 28.09% <ø> (ø)
src/EnvelopeCreator/CreateDocument.php 93.33% <ø> (ø)
src/EnvelopeCreator/EnvelopeCreator.php 73.91% <ø> (ø)
src/Filesystem/AbstractFilesystemDecorator.php 0.00% <0.00%> (ø)
src/Filesystem/FilesystemDecorator.php 5.26% <5.26%> (ø)
src/DependencyInjection/DocusignExtension.php 98.70% <100.00%> (+0.02%) ⬆️
src/Exception/FileNotFoundException.php 100.00% <100.00%> (ø)
src/Filesystem/FilesystemInterface.php 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c185b...fefc871. Read the comment docs.

@vincentchalamon vincentchalamon marked this pull request as ready for review July 22, 2021 13:56
@VincentLanglet
Copy link

@GregoireHebert Hi, would you have some time to review/merge/release this ? :)

@GregoireHebert GregoireHebert merged commit 17b9ae8 into main Aug 20, 2021
@GregoireHebert GregoireHebert deleted the feat/flysystem2 branch August 20, 2021 18:42
@GregoireHebert
Copy link
Owner

sorry for the delay, thank you @VincentLanglet and @vincentchalamon :)
just tagged 5.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants