Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 6.0 + test with it and PHP 8.1 #126

Merged
merged 16 commits into from Jan 17, 2022
Merged

Conversation

vincentchalamon
Copy link
Collaborator

@vincentchalamon vincentchalamon commented Dec 2, 2021

Note: symfony/debug is not compatible with psr/log:^3.0

@vincentchalamon vincentchalamon force-pushed the chore/dependencies branch 5 times, most recently from 887b0ff to 382ebdc Compare December 29, 2021 11:02
@vincentchalamon vincentchalamon force-pushed the chore/dependencies branch 3 times, most recently from 7313a4a to 65ef48a Compare December 29, 2021 12:50
@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #126 (36a9e3c) into main (0bc143d) will decrease coverage by 0.32%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #126      +/-   ##
============================================
- Coverage     71.70%   71.37%   -0.33%     
- Complexity      261      262       +1     
============================================
  Files            41       41              
  Lines          1138     1125      -13     
============================================
- Hits            816      803      -13     
  Misses          322      322              
Flag Coverage Δ
phpunit 71.37% <91.66%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/EnvelopeBuilder.php 28.09% <ø> (+0.23%) ⬆️
src/EnvelopeCreator/EnvelopeCreator.php 72.72% <ø> (-1.19%) ⬇️
...velopeCreator/TraceableEnvelopeBuilderCallable.php 0.00% <ø> (ø)
src/Twig/Extension/ClickwrapExtension.php 86.66% <0.00%> (ø)
src/DependencyInjection/DocusignExtension.php 98.70% <100.00%> (ø)
src/EnvelopeCreator/SendEnvelope.php 93.75% <100.00%> (-0.37%) ⬇️
src/Routing/DocusignLoader.php 80.00% <100.00%> (+1.05%) ⬆️
src/Translator/TranslatorAwareTrait.php 71.42% <100.00%> (ø)
src/DocusignBundle.php 0.00% <0.00%> (-75.00%) ⬇️
...ependencyInjection/Compiler/PluginCompilerPass.php 0.00% <0.00%> (-55.56%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc143d...36a9e3c. Read the comment docs.

@coveralls
Copy link

coveralls commented Dec 29, 2021

Pull Request Test Coverage Report for Build 1706854991

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • 16 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+1.2%) to 75.791%

Files with Coverage Reduction New Missed Lines %
src/EventSubscriber/AuthorizationCodeEventSubscriber.php 1 93.1%
src/DependencyInjection/Configuration.php 2 97.92%
src/EnvelopeCreator/TraceableEnvelopeBuilderCallable.php 2 0%
src/Filesystem/FilesystemDecorator.php 2 0%
src/Grant/JwtGrant.php 2 0%
src/DocusignBundle.php 3 0%
src/DependencyInjection/Compiler/PluginCompilerPass.php 4 0%
Totals Coverage Status
Change from base Build 1339090552: 1.2%
Covered Lines: 767
Relevant Lines: 1012

💛 - Coveralls

@vincentchalamon vincentchalamon linked an issue Dec 29, 2021 that may be closed by this pull request
Copy link
Owner

@GregoireHebert GregoireHebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vincent :)
Minor change (I am being nitpicking here) before merging ^^

features/src/Kernel.php Outdated Show resolved Hide resolved
Co-authored-by: Grégoire Hébert <gregoire@les-tilleuls.coop>
@GregoireHebert GregoireHebert merged commit 652ecf0 into main Jan 17, 2022
@GregoireHebert GregoireHebert deleted the chore/dependencies branch January 17, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to docusign/esign-client:^6.0
3 participants