Fix build on latest musl #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getopt(3) is found in unistd.h on all POSIX systems and we make no use of any of the GNU specific argp extensions. Include unistd.h directly to allow building with musl on linux, whilst retaining compatibility with glibc and other unices. Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Ensure that off_t is always 64-bit by specifying -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 this will ensure that normal lseek() function is same as lseek64 This helps compiling on latest musl where lseek64 and friends are not available Signed-off-by: Khem Raj <raj.khem@gmail.com>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jun 15, 2023
We previously had 1 musl patch for getopt usage, I'm replacing that with one from an upstream PR [1], also adding a new patch from that upstream PR. [1] Gregwar/fatcat#34 Closes: https://bugs.gentoo.org/908541 Signed-off-by: Ben Kohler <bkohler@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.