The graph-model on the default environment should be invalid. Working…

… without a model is useless and a pitfall for incorrect code.
Gremlinq · May 11, 2023 · 09a2cbd · 09a2cbd
1 parent f51b125
commit 09a2cbd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/Core/Environment/GremlinQueryEnvironment.cs b/src/Core/Environment/GremlinQueryEnvironment.cs
@@ -134,6 +134,7 @@ public bool TryConvert(TSource source, ITransformer recurse, out TimeSpan value)
             NullLogger.Instance);
 
         public static readonly IGremlinQueryEnvironment Default = Empty
+            .UseModel(GraphModel.Invalid)
             .UseSerializer(Serializer.Default)
             .UseExecutor(GremlinQueryExecutor.Invalid)
             .UseDeserializer(Deserializer.Default);

diff --git a/test/Support.NewtonsoftJson.Tests/TansformerTest.cs b/test/Support.NewtonsoftJson.Tests/TansformerTest.cs
@@ -135,35 +135,35 @@ public Task Transform_to_List()
         {
             var token = JObject.Parse("{ \"@type\": \"g:List\", \"@value\": [ { \"@type\": \"g:Traverser\", \"@value\": { \"bulk\": { \"@type\": \"g:Int64\", \"@value\": 3 }, \"value\": { \"@type\": \"g:Map\", \"@value\": [ \"id\", { \"@type\": \"g:Int64\", \"@value\": 184 }, \"label\", \"Label\", \"properties\", { \"@type\": \"g:Map\", \"@value\": [] } ] } } } ]}");
 
-            return Verify(GremlinQueryEnvironment.Default
+            return Verify(GremlinQueryEnvironment.Empty
                 .UseNewtonsoftJson()
                 .Deserializer
                 .TransformTo<List<object>>()
-                .From(token, GremlinQueryEnvironment.Default));
+                .From(token, GremlinQueryEnvironment.Empty));
         }
 
         [Fact]
         public Task Transform_to_array()
         {
             var token = JObject.Parse("{ \"@type\": \"g:List\", \"@value\": [ { \"@type\": \"g:Traverser\", \"@value\": { \"bulk\": { \"@type\": \"g:Int64\", \"@value\": 3 }, \"value\": { \"@type\": \"g:Map\", \"@value\": [ \"id\", { \"@type\": \"g:Int64\", \"@value\": 184 }, \"label\", \"Label\", \"properties\", { \"@type\": \"g:Map\", \"@value\": [] } ] } } } ]}");
 
-            return Verify(GremlinQueryEnvironment.Default
+            return Verify(GremlinQueryEnvironment.Empty
                 .UseNewtonsoftJson()
                 .Deserializer
                 .TransformTo<object[]>()
-                .From(token, GremlinQueryEnvironment.Default));
+                .From(token, GremlinQueryEnvironment.Empty));
         }
 
         [Fact]
         public Task Transform_to_IEnumerable()
         {
             var token = JObject.Parse("{ \"@type\": \"g:List\", \"@value\": [ { \"@type\": \"g:Traverser\", \"@value\": { \"bulk\": { \"@type\": \"g:Int64\", \"@value\": 3 }, \"value\": { \"@type\": \"g:Map\", \"@value\": [ \"id\", { \"@type\": \"g:Int64\", \"@value\": 184 }, \"label\", \"Label\", \"properties\", { \"@type\": \"g:Map\", \"@value\": [] } ] } } } ]}");
 
-            var result = GremlinQueryEnvironment.Default
+            var result = GremlinQueryEnvironment.Empty
                 .UseNewtonsoftJson()
                 .Deserializer
                 .TransformTo<IEnumerable<object>>()
-                .From(token, GremlinQueryEnvironment.Default);
+                .From(token, GremlinQueryEnvironment.Empty);
 
             return Verify(result);
         }
@@ -173,11 +173,11 @@ public Task Transform_from_JArray_to_object()
         {
             var token = JObject.Parse("{ \"@type\": \"g:List\", \"@value\": [ { \"@type\": \"g:Traverser\", \"@value\": { \"bulk\": { \"@type\": \"g:Int64\", \"@value\": 3 }, \"value\": { \"@type\": \"g:Map\", \"@value\": [ \"id\", { \"@type\": \"g:Int64\", \"@value\": 184 }, \"label\", \"Label\", \"properties\", { \"@type\": \"g:Map\", \"@value\": [] } ] } } } ]}");
 
-            return Verify(GremlinQueryEnvironment.Default
+            return Verify(GremlinQueryEnvironment.Empty
                 .UseNewtonsoftJson()
                 .Deserializer
                 .TransformTo<object>()
-                .From(token, GremlinQueryEnvironment.Default));
+                .From(token, GremlinQueryEnvironment.Empty));
         }
     }
 }