-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonExtensionData support #82
Comments
I don't have a definitive opinion about whether to embrace such a feature or not. My initial feelings towards this are:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
this would be very helpful @mcgear. Did you get any further with this and complete the implementation? if not, what did you do instead? |
Hi @danielcweber! I understand that there was no fix on the code regarding this right? Is there any suggested workaround for supporting dynamic properties? I mean not strongly typed properties, that might be added by the user. |
Is your feature request related to a problem? Please describe.
In order to achieve some of our various logic, we have been leveraging JsonExtensionData concepts from JSON.NET. In the previous supporting library we were using, we were able to easily pass across these metadata. Now converting everything in our Graph over to Gremlinq, we have hit an error where JsonExtensionData blows up the Graph calls.
The way that JsonExtensionData works, is it typically flattens what is in the Dictionary property down to properties on the actual base object. leveraging this, we can do some dynamic data storing.
After cracking open the code and adding a few new tests that broke at first, the largest issue seems to be the relation properties have to the GraphModel.
Describe the solution you'd like
Ideally, when processing a Property with JsonExtensionData attribute, the desired behavior would be that every item in the dictionary show up on the base level object written to the graph.
Describe alternatives you've considered
I have jumped into my own fork and solved issues around AddV, Property, and Where as a proof of concept, and it seems to be working. Seeing as i don't have the experience in your code base yet, i thought i would pause and surface this here. I figure there are still changes required to support things like FirstAsync and ToArrayAsync, more importantly you may have a completely different thought and approach than what i was able to figure out to get it working.
The text was updated successfully, but these errors were encountered: