Rework deserializer #831
Merged
Rework deserializer #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
danielcweber
force-pushed
the
ReworkDeserializer
branch
from
0c2bf50
to
a0693e7
Compare
…ue) pattern, so in a subsequent update, we can distinguish a non-existent return for value types.
… won't have a cached instance for every type.
…remlinQueryExecutionResultDeserializer will be missing soon.
…d is being removed.
danielcweber
force-pushed
the
ReworkDeserializer
branch
from
a0693e7
to
d584581
Compare
…a base class and a static From method. To be refined further.
…e in calling an override with a modified serialized value, but instead, recurse should be called.
…pes, get them from the environment. Use ToObject.
… that TSerialized is the actual type of the serialized instance, no need to check 2 ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IGremlinQueryFragmentDeserializerswitches itsDeserializesignature from returning an object? (where, when null is returned, it is unclear whether deserialization failed or null is the actual return value) to abool(...out object? value)signature, like for framework Try... methods. Boxing still occurs, however, we add some syntactic sugar extensions to get typed returns. These are called likeTryDeserialize<TFragmentType>().From(serializedValue, environment). This also works for type instances:TryDeserialize(type).From(serializedValue, environment).