Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: limit total rows copied in COPY TABLE FROM with LIMIT segment #946

Merged
merged 2 commits into from May 17, 2024

Conversation

irenjj
Copy link
Contributor

@irenjj irenjj commented May 10, 2024

What's Changed in this PR

releated to: GreptimeTeam/greptimedb#3910

Checklist

  • Please ensure that the content in summary.yml matches the current document structure when you changed the document structure.
  • This change requires follow-up update in localized docs.

@irenjj irenjj requested review from nicecui and a team as code owners May 10, 2024 13:06
@nicecui nicecui requested review from evenyag and waynexia May 12, 2024 06:14
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Comment inline.

@@ -119,6 +120,10 @@ You can set the following **CONNECTION** options:
| `ENABLE_VIRTUAL_HOST_STYLE` | If you use virtual hosting to address the bucket, set it to "true".| Optional |
| `SESSION_TOKEN` | Your temporary credential for connecting the AWS S3 service. | Optional |

#### LIMIT

You can use `LIMIT` to restrict maximum number of rows inserted at once.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we have a default value here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in #3889 we disabled the default value in Limit:

Change the limit behavior to

do not limit by default

@tisonkun tisonkun merged commit b1f426c into GreptimeTeam:main May 17, 2024
3 checks passed
@irenjj irenjj deleted the limit_segment branch May 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants