Set RowKeyDescriptor::enable_version_column to false by default

GreptimeTeam · Jul 15, 2022 · e62fa89 · e62fa89
1 parent 7c6f5ef
commit e62fa89
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/storage/src/memtable/tests.rs b/src/storage/src/memtable/tests.rs
@@ -15,6 +15,7 @@ const MEMTABLE_ID: MemtableId = 1;
 pub fn schema_for_test() -> MemtableSchema {
     // Just build a region desc and use its columns_row_key metadata.
     let desc = RegionDescBuilder::new("test")
+        .enable_version_column(true)
         .push_value_column(("v1", LogicalTypeId::UInt64, true))
         .build();
     let metadata: RegionMetadata = desc.try_into().unwrap();

diff --git a/src/storage/src/region/tests.rs b/src/storage/src/region/tests.rs
@@ -20,6 +20,7 @@ async fn test_new_region() {
     let region_id = 0;
     let region_name = "region-0";
     let desc = RegionDescBuilder::new(region_name)
+        .enable_version_column(true)
         .push_key_column(("k1", LogicalTypeId::Int32, false))
         .push_value_column(("v1", LogicalTypeId::Float32, true))
         .build();

diff --git a/src/store-api/src/storage/descriptors.rs b/src/store-api/src/storage/descriptors.rs
@@ -134,7 +134,7 @@ impl RowKeyDescriptorBuilder {
         Self {
             columns: Vec::new(),
             timestamp,
-            enable_version_column: true,
+            enable_version_column: false,
         }
     }
 
@@ -257,7 +257,7 @@ mod tests {
 
         let desc = RowKeyDescriptorBuilder::new(timestamp.clone()).build();
         assert!(desc.columns.is_empty());
-        assert!(desc.enable_version_column);
+        assert!(!desc.enable_version_column);
 
         let desc = RowKeyDescriptorBuilder::new(timestamp.clone())
             .columns_capacity(1)
@@ -269,7 +269,7 @@ mod tests {
             )
             .build();
         assert_eq!(2, desc.columns.len());
-        assert!(desc.enable_version_column);
+        assert!(!desc.enable_version_column);
 
         let desc = RowKeyDescriptorBuilder::new(timestamp)
             .enable_version_column(false)