Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl Logstore::read by LogFile::create_stream #124

Merged
merged 2 commits into from Aug 2, 2022

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Aug 1, 2022

No description provided.

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #124 (1dd65e4) into develop (f06968f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #124      +/-   ##
===========================================
+ Coverage    70.35%   70.40%   +0.04%     
===========================================
  Files          205      205              
  Lines        14395    14402       +7     
===========================================
+ Hits         10128    10140      +12     
+ Misses        4267     4262       -5     
Flag Coverage Δ
rust 70.40% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/log-store/src/fs/file.rs 84.58% <100.00%> (-0.42%) ⬇️
src/log-store/src/fs/log.rs 73.80% <100.00%> (+3.63%) ⬆️
src/log-store/src/fs/noop.rs 29.62% <100.00%> (ø)
src/storage/src/wal.rs 88.88% <100.00%> (ø)
src/table-engine/src/engine.rs 98.11% <0.00%> (-0.94%) ⬇️
src/table/src/engine.rs 100.00% <0.00%> (ø)
src/datanode/src/error.rs 50.72% <0.00%> (ø)
src/table-engine/src/error.rs 86.20% <0.00%> (+6.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

src/log-store/src/fs/log.rs Outdated Show resolved Hide resolved
src/log-store/src/fs/log.rs Show resolved Hide resolved
src/log-store/src/fs/log.rs Outdated Show resolved Hide resolved
src/log-store/src/fs/file.rs Show resolved Hide resolved
@v0y4g3r v0y4g3r requested a review from evenyag August 2, 2022 02:52
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit 868098d into develop Aug 2, 2022
@v0y4g3r v0y4g3r deleted the feat/impl_log_read branch August 2, 2022 03:14
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: bridge LogStore::read to LogFile::create_stream

* fix some CR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants