feat: upgrade opendal #1245
Merged
feat: upgrade opendal #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0y4g3r
force-pushed
the
feat/upgrade-opendal
branch
from
f2fa12c
to
34324e1
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1245 +/- ##
===========================================
- Coverage 85.60% 85.32% -0.28%
===========================================
Files 495 495
Lines 73397 73378 -19
===========================================
- Hits 62828 62612 -216
- Misses 10569 10766 +197 |
v0y4g3r
requested review from
evenyag and
killme2008
and removed request for
evenyag
fengjiachun
approved these changes
Mar 27, 2023
v0y4g3r
force-pushed
the
feat/upgrade-opendal
branch
from
34324e1
to
a25c923
Compare
killme2008
reviewed
Mar 27, 2023
Closed
evenyag
reviewed
Apr 24, 2023
Comment on lines
+73
to
+78
| let file_full_path = format!("{}{}", self.path, filename); | ||
| let _ = self.object_store.stat(&file_full_path).await.context( | ||
| error::ListObjectsSnafu { | ||
| path: &file_full_path, | ||
| }, | ||
| )?; |
There was a problem hiding this comment.
Is it possible that a file doesn't exist while listing the data source?
There was a problem hiding this comment.
Is it possible that a file doesn't exist while listing the data source?
OpenDAL always raises an error if target file path does not exist.
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: upgrade opendal * chore: finish upgrading opendal * fix: clippy complaints * fix some tests * fix: all unit tests * chore: rebase develop * fix: sqlness tests * optimize imports * chore: rebase develop * doc: add todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Upgrades opendal from 0.27 to 0.30. This is the prerequisite of #1248 .
The major changes are:
ObjectStorenow takes aBuilderinstead of anAccessor.Objectis completely removed from opendal in #1477. Thus lots of file read/write stuff needs rewrite.list/scannow returns a stream ofEntryinstead ofObject.Checklist
Refer to a related PR or issue link (optional)