Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support "delete" in distributed mode #1441

Merged
merged 2 commits into from Apr 24, 2023

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Support "delete" in distributed mode, both in GRPC and SQL.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

close #755

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #1441 (203a2f9) into develop (22b5a94) will decrease coverage by 0.32%.
The diff coverage is 96.59%.

@@             Coverage Diff             @@
##           develop    #1441      +/-   ##
===========================================
- Coverage    85.71%   85.39%   -0.32%     
===========================================
  Files          543      545       +2     
  Lines        81278    81773     +495     
===========================================
+ Hits         69666    69830     +164     
- Misses       11612    11943     +331     

src/frontend/src/table.rs Outdated Show resolved Hide resolved
src/frontend/src/table/delete.rs Outdated Show resolved Hide resolved
src/frontend/src/table/insert.rs Outdated Show resolved Hide resolved
src/partition/src/partition.rs Outdated Show resolved Hide resolved
src/partition/src/partition.rs Outdated Show resolved Hide resolved
@MichaelScofield
Copy link
Collaborator Author

resolved, PTAL @evenyag

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag merged commit 17daf4c into GreptimeTeam:develop Apr 24, 2023
11 checks passed
@MichaelScofield MichaelScofield deleted the feat/distribute-delete branch April 24, 2023 04:42
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: support "delete" in distributed mode

* fix: resolve PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for delete
3 participants