New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support "delete" in distributed mode #1441
Merged
evenyag
merged 2 commits into
GreptimeTeam:develop
from
MichaelScofield:feat/distribute-delete
Apr 24, 2023
Merged
feat: support "delete" in distributed mode #1441
evenyag
merged 2 commits into
GreptimeTeam:develop
from
MichaelScofield:feat/distribute-delete
Apr 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1441 +/- ##
===========================================
- Coverage 85.71% 85.39% -0.32%
===========================================
Files 543 545 +2
Lines 81278 81773 +495
===========================================
+ Hits 69666 69830 +164
- Misses 11612 11943 +331 |
MichaelScofield
force-pushed
the
feat/distribute-delete
branch
from
April 23, 2023 02:54
9d96de1
to
ce377dc
Compare
evenyag
reviewed
Apr 23, 2023
MichaelScofield
force-pushed
the
feat/distribute-delete
branch
from
April 24, 2023 02:49
b0ef957
to
203a2f9
Compare
resolved, PTAL @evenyag |
fengjiachun
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
evenyag
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: support "delete" in distributed mode * fix: resolve PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Support "delete" in distributed mode, both in GRPC and SQL.
Checklist
Refer to a related PR or issue link (optional)
close #755