Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aggregate #147

Merged
merged 1 commit into from
Aug 25, 2022
Merged

feat: aggregate #147

merged 1 commit into from
Aug 25, 2022

Conversation

clickme-zxy
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #147 (f76a876) into develop (2373d67) will increase coverage by 0.68%.
The diff coverage is 85.29%.

❗ Current head f76a876 differs from pull request most recent head ce6e838. Consider uploading reports for the commit ce6e838 to get more accurate results

@@             Coverage Diff             @@
##           develop     #147      +/-   ##
===========================================
+ Coverage    75.50%   76.19%   +0.68%     
===========================================
  Files          241      252      +11     
  Lines        18985    20622    +1637     
===========================================
+ Hits         14335    15713    +1378     
- Misses        4650     4909     +259     
Flag Coverage Δ
rust 76.19% <85.29%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/query/src/error.rs 72.88% <0.00%> (-8.26%) ⬇️
src/common/function/src/scalars/aggregate/diff.rs 57.43% <57.43%> (ø)
...tion/src/scalars/aggregate/scipy_stats_norm_cdf.rs 84.39% <84.39%> (ø)
...tion/src/scalars/aggregate/scipy_stats_norm_pdf.rs 84.39% <84.39%> (ø)
...c/common/function/src/scalars/aggregate/polyval.rs 85.71% <85.71%> (ø)
...ommon/function/src/scalars/aggregate/percentile.rs 90.58% <90.58%> (ø)
src/common/function/src/scalars/aggregate/mean.rs 91.17% <91.17%> (ø)
...rc/common/function/src/scalars/aggregate/argmax.rs 94.01% <94.01%> (ø)
...rc/common/function/src/scalars/aggregate/argmin.rs 95.12% <95.12%> (ø)
src/common/function/src/scalars/aggregate/mod.rs 89.74% <95.65%> (+7.39%) ⬆️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@clickme-zxy clickme-zxy changed the title argmax feat/aggregate/argmax Aug 8, 2022
@clickme-zxy clickme-zxy changed the title feat/aggregate/argmax feat: aggregate/argmax Aug 8, 2022
@clickme-zxy clickme-zxy force-pushed the feat/aggregate_argmax branch 5 times, most recently from 0f4451a to f56546f Compare August 12, 2022 02:55
@clickme-zxy clickme-zxy changed the title feat: aggregate/argmax feat: aggregate Aug 16, 2022
@clickme-zxy clickme-zxy force-pushed the feat/aggregate_argmax branch 20 times, most recently from c45e9f6 to 622ea55 Compare August 19, 2022 02:51
@clickme-zxy clickme-zxy force-pushed the feat/aggregate_argmax branch 2 times, most recently from e3a3937 to e0fa7a6 Compare August 24, 2022 03:03
src/common/function/src/scalars/aggregate/argmax.rs Outdated Show resolved Hide resolved
src/common/function/src/scalars/aggregate/argmin.rs Outdated Show resolved Hide resolved
src/common/function/src/scalars/aggregate/argmin.rs Outdated Show resolved Hide resolved
src/common/function/src/scalars/aggregate/argmin.rs Outdated Show resolved Hide resolved
src/common/function/src/scalars/aggregate/argmin.rs Outdated Show resolved Hide resolved
src/common/function/src/scalars/aggregate/stddev.rs Outdated Show resolved Hide resolved
src/query/tests/polyval_test.rs Outdated Show resolved Hide resolved
src/common/function/src/scalars/aggregate/argmax.rs Outdated Show resolved Hide resolved
src/common/function/src/scalars/aggregate/argmax.rs Outdated Show resolved Hide resolved
src/common/function/src/scalars/aggregate/argmax.rs Outdated Show resolved Hide resolved
src/common/function/src/scalars/aggregate/argmax.rs Outdated Show resolved Hide resolved
src/common/function/src/scalars/aggregate/argmin.rs Outdated Show resolved Hide resolved
src/common/function/src/scalars/aggregate/argmin.rs Outdated Show resolved Hide resolved
@clickme-zxy clickme-zxy force-pushed the feat/aggregate_argmax branch 9 times, most recently from 4a4f2ce to 44502f9 Compare August 25, 2022 09:28
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag merged commit 99cf553 into develop Aug 25, 2022
@evenyag evenyag deleted the feat/aggregate_argmax branch August 25, 2022 11:44
clickme-zxy added a commit that referenced this pull request Aug 26, 2022
clickme-zxy added a commit that referenced this pull request Aug 26, 2022
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants