New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support gcs storage #1781
feat: support gcs storage #1781
Conversation
|
|
Right now the |
I implemented #1611, but it seems like the |
@NiwakaDev Let me try it. Thanks a lot. There is a conflict have to be resolved. |
104bd6d
to
b664ce6
Compare
I addressed this. |
@NiwakaDev I have to apply the GCS account and token, sorry for the late response. I am looking into it today. |
I'm sorry for the late reply.
Thank you for looking it. |
Looks like it's a concurrent issue between tests. The HTTP client was stopped while other tests were running. I am not quite sure the OpenDAL GCS backend implementation working properly. I'll look into it. |
Thanks a lot for investigating the cause.
Ok. I'll also re-check gcs setting. |
@NiwakaDev I think we can merge this PR first, the test concurrent issue can be fixed later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR adds support gcs storage.
Checklist
Refer to a related PR or issue link (optional)
#1611