Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve influxdb v2 api compability #1831

Merged
merged 2 commits into from Jun 27, 2023

Conversation

fengys1996
Copy link
Contributor

@fengys1996 fengys1996 commented Jun 26, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr mainly improve influxdb v2 api compability.

  • Write using the curl command as shown below
    curl -i -XPOST "http://localhost:4000/v1/influxdb/api/v2/write?bucket=public&precision=ms" \
    --data-binary \
    'monitor,host=127.0.0.1 cpu=0.1,memory=0.4 1667446797450
     monitor,host=127.0.0.2 cpu=0.2,memory=0.3 1667446798450
     monitor,host=127.0.0.1 cpu=0.5,memory=0.2 1667446798450'
  • Write using Go sdk, an example here

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

fix #1815

@fengys1996 fengys1996 added the Doc update required This change requires document update on https://github.com/GreptimeTeam/docs label Jun 26, 2023
@fengys1996 fengys1996 marked this pull request as ready for review June 27, 2023 01:27
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1831 (d98e986) into develop (fd412b7) will decrease coverage by 0.24%.
The diff coverage is 64.28%.

@@             Coverage Diff             @@
##           develop    #1831      +/-   ##
===========================================
- Coverage    86.45%   86.22%   -0.24%     
===========================================
  Files          585      587       +2     
  Lines        95432    95702     +270     
===========================================
+ Hits         82509    82520      +11     
- Misses       12923    13182     +259     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

src/servers/src/http/influxdb.rs Show resolved Hide resolved
@MichaelScofield MichaelScofield merged commit 99f0479 into GreptimeTeam:develop Jun 27, 2023
11 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc update required This change requires document update on https://github.com/GreptimeTeam/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve influx v2 api compability
3 participants