Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid confusion in desc table #2272

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

In the output of DESC TABLE, we have used the name Field (following MySQL's convention), but our Time Series Data Model also includes Field (Tag, Field, Timestamp). This may confuse users.

before

+-----------+----------------------+-----+------+---------+---------------+
| Field     | Type                 | Key | Null | Default | Semantic Type |
+-----------+----------------------+-----+------+---------+---------------+
| ts        | TimestampMillisecond | PRI | NO   |         | TIMESTAMP     |
| collector | String               | PRI | YES  |         | TAG           |
| host      | String               | PRI | YES  |         | TAG           |
| val       | Float64              |     | YES  |         | FIELD         |
+-----------+----------------------+-----+------+---------+---------------+

after

+-----------+----------------------+-----+------+---------+---------------+
| Column    | Type                 | Key | Null | Default | Semantic Type |
+-----------+----------------------+-----+------+---------+---------------+
| ts        | TimestampMillisecond | PRI | NO   |         | TIMESTAMP     |
| collector | String               | PRI | YES  |         | TAG           |
| host      | String               | PRI | YES  |         | TAG           |
| val       | Float64              |     | YES  |         | FIELD         |
+-----------+----------------------+-----+------+---------+---------------+

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@fengjiachun fengjiachun requested review from killme2008, sunng87, evenyag and MichaelScofield and removed request for killme2008, sunng87 and evenyag August 28, 2023 10:34
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #2272 (529ea69) into develop (96fd17a) will decrease coverage by 0.42%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2272      +/-   ##
===========================================
- Coverage    85.16%   84.74%   -0.42%     
===========================================
  Files          709      709              
  Lines       116457   116457              
===========================================
- Hits         99179    98691     -488     
- Misses       17278    17766     +488     

@MichaelScofield MichaelScofield added this pull request to the merge queue Aug 28, 2023
Merged via the queue into GreptimeTeam:develop with commit c02ac36 Aug 28, 2023
13 checks passed
@fengjiachun fengjiachun deleted the feat/desc-table-column-schema branch August 29, 2023 08:20
@sunng87 sunng87 added the Doc update required This change requires document update on https://github.com/GreptimeTeam/docs label Aug 31, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
feat: Field to Column to aviod confusion in DESC TABLE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc update required This change requires document update on https://github.com/GreptimeTeam/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants