Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only allow timestamp type as time index #2281

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Aug 29, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Only allow timestamp type as time index.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#1415

@killme2008 killme2008 marked this pull request as ready for review August 30, 2023 04:12
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #2281 (01081c9) into develop (68600a2) will decrease coverage by 0.44%.
Report is 3 commits behind head on develop.
The diff coverage is 91.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2281      +/-   ##
===========================================
- Coverage    85.21%   84.77%   -0.44%     
===========================================
  Files          715      715              
  Lines       117383   117458      +75     
===========================================
- Hits        100025    99578     -447     
- Misses       17358    17880     +522     

@MichaelScofield MichaelScofield added the Doc update required This change requires document update on https://github.com/GreptimeTeam/docs label Aug 30, 2023
src/sql/src/parsers/create_parser.rs Outdated Show resolved Hide resolved
tests/cases/standalone/cte/cte.result Outdated Show resolved Hide resolved
@killme2008
Copy link
Contributor Author

@MichaelScofield PTAL

@fengjiachun fengjiachun changed the base branch from develop to migrate-region-server August 30, 2023 11:02
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@MichaelScofield MichaelScofield merged commit 244584c into GreptimeTeam:migrate-region-server Aug 30, 2023
15 checks passed
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* feat: only allow timestamp data type as time index

* test: update sqltest cases, todo: need some fixes

* fix: sqlness tests

* fix: forgot adding back cte test

* chore: style
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* feat: only allow timestamp data type as time index

* test: update sqltest cases, todo: need some fixes

* fix: sqlness tests

* fix: forgot adding back cte test

* chore: style
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* feat: only allow timestamp data type as time index

* test: update sqltest cases, todo: need some fixes

* fix: sqlness tests

* fix: forgot adding back cte test

* chore: style
WenyXu pushed a commit to WenyXu/greptimedb that referenced this pull request Sep 13, 2023
* feat: only allow timestamp data type as time index

* test: update sqltest cases, todo: need some fixes

* fix: sqlness tests

* fix: forgot adding back cte test

* chore: style
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: only allow timestamp data type as time index

* test: update sqltest cases, todo: need some fixes

* fix: sqlness tests

* fix: forgot adding back cte test

* chore: style
@killme2008 killme2008 deleted the feature/time-index-types branch January 16, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc update required This change requires document update on https://github.com/GreptimeTeam/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants