fix: can't adding new columns as primary key #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
force-pushed
the
feature/add-primary-key-column
branch
from
2278866
to
79f15b7
Compare
MichaelScofield
approved these changes
Sep 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## migrate-region-server #2310 +/- ##
========================================================
Coverage ? 78.77%
========================================================
Files ? 717
Lines ? 116490
Branches ? 0
========================================================
Hits ? 91770
Misses ? 24720
Partials ? 0 |
|
@v0y4g3r @fengjiachun Please take a look. |
Merged
via the queue into
GreptimeTeam:migrate-region-server
with commit Sep 4, 2023
b1f5a88
11 checks passed
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
Sep 13, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Make the
altersql statement can add new columns as the primary key.Try to fix #1308
TODO:
Checklist
Refer to a related PR or issue link (optional)
Close #1308