Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distribute truncate table in region server #2414

Merged
merged 6 commits into from Sep 26, 2023

Conversation

DevilExileSu
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Implement truncate table in region server.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@DevilExileSu DevilExileSu force-pushed the feat/distribute-truncate branch 3 times, most recently from c4f4ce6 to 07b8cb9 Compare September 20, 2023 16:19
@DevilExileSu DevilExileSu marked this pull request as ready for review September 23, 2023 11:11
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #2414 (bad04cc) into develop (73842f1) will decrease coverage by 0.37%.
Report is 9 commits behind head on develop.
The diff coverage is 6.52%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2414      +/-   ##
===========================================
- Coverage    84.97%   84.61%   -0.37%     
===========================================
  Files          725      725              
  Lines       115463   115362     -101     
===========================================
- Hits         98120    97608     -512     
- Misses       17343    17754     +411     

Cargo.toml Outdated Show resolved Hide resolved
src/common/meta/src/ddl/truncate_table.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/truncate_table.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/truncate_table.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

@WenyXu WenyXu self-requested a review September 26, 2023 07:45
@evenyag evenyag added this pull request to the merge queue Sep 26, 2023
Merged via the queue into GreptimeTeam:develop with commit 7fc9604 Sep 26, 2023
13 checks passed
@DevilExileSu DevilExileSu deleted the feat/distribute-truncate branch September 26, 2023 12:06
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: distribute truncate table

* chore: add metrics for truncate table

* test: add sqlness test

* chore: cr

* test: add multi truncate

* chore: add trace id to the header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants