Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert datetime to chrono datetime #2497

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Sep 26, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

a forgotten corner

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #2497 (f849dfd) into develop (230a302) will decrease coverage by 0.43%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2497      +/-   ##
===========================================
- Coverage    85.02%   84.60%   -0.43%     
===========================================
  Files          724      724              
  Lines       115337   115346       +9     
===========================================
- Hits         98071    97592     -479     
- Misses       17266    17754     +488     

@evenyag evenyag added this pull request to the merge queue Sep 26, 2023
Merged via the queue into GreptimeTeam:develop with commit a428241 Sep 26, 2023
13 checks passed
@zhongzc zhongzc deleted the zhongzc/fix-datetime-convertion branch September 26, 2023 09:15
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix: convert datetime to chrono datetime

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

* chore: typo

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

* fix the bad fix

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

---------

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants