Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: renaming kv directory to metadata #2549

Merged
merged 3 commits into from Oct 9, 2023

Conversation

Lilit0x
Copy link
Contributor

@Lilit0x Lilit0x commented Oct 9, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

The KV directory has been renamed to metadata to provide more useful info for users.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

#2493

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2549 (f39c8a8) into develop (ce3c10a) will decrease coverage by 0.33%.
Report is 4 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2549      +/-   ##
===========================================
- Coverage    85.34%   85.02%   -0.33%     
===========================================
  Files          737      737              
  Lines       117409   117737     +328     
===========================================
- Hits        100206   100101     -105     
- Misses       17203    17636     +433     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008
Copy link
Contributor

@waynexia Please take a look.

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Lilit0x

@waynexia waynexia added this pull request to the merge queue Oct 9, 2023
Merged via the queue into GreptimeTeam:develop with commit 19f300f Oct 9, 2023
13 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix: renamed kv directory to metadata directory

* fix: changed function name

* fix: changed function name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants