Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explain range query #2664

Merged
merged 2 commits into from Oct 30, 2023
Merged

fix: explain range query #2664

merged 2 commits into from Oct 30, 2023

Conversation

Taylor-lagrange
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Make range query can be explain and analyze

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Build Explain and Analyze plan manually when range plan rewrite
  • Add Sqlness test

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited

Codecov Report

Merging #2664 (aa2267d) into develop (5d8b0e8) will decrease coverage by 0.30%.
Report is 2 commits behind head on develop.
The diff coverage is 16.66%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2664      +/-   ##
===========================================
- Coverage    84.91%   84.61%   -0.30%     
===========================================
  Files          743      743              
  Lines       120812   120603     -209     
===========================================
- Hits        102582   102047     -535     
- Misses       18230    18556     +326

waynexia
waynexia reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/query/src/range_select/plan_rewrite.rs Show resolved Hide resolved
evenyag
evenyag approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Oct 30, 2023
Merged via the queue into GreptimeTeam:develop with commit d2f3793 Oct 30, 2023
12 checks passed
@Taylor-lagrange Taylor-lagrange deleted the fix-range-explain branch October 31, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag evenyag approved these changes

@waynexia waynexia waynexia approved these changes

@killme2008 killme2008 Awaiting requested review from killme2008

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taylor-lagrange @evenyag @waynexia