Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: rfc of inverted index for SST file #2693

Merged
merged 4 commits into from Nov 6, 2023
Merged

docs: rfc of inverted index for SST file #2693

merged 4 commits into from Nov 6, 2023

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Nov 3, 2023 •
edited

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

rendered

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@zhongzc
docs: rfc of inverted index for SST file
8c4d999 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
fengjiachun
fengjiachun approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

killme2008
killme2008 reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: if we want to support other index types such as geospatial indexing, is the API design extensible?

docs/rfcs/2023-11-03-inverted-index.md Show resolved Hide resolved
@zhongzc
docs: add row_count_in_group
fae2082 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc
docs: fix spell check
6163cb9 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc
docs: update api
a017ede 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc
Copy link
Contributor Author

zhongzc commented Nov 6, 2023 •
edited

Question: if we want to support other index types such as geospatial indexing, is the API design extensible?

We have designed the Index data to be housed within Puffin. As a container, Puffin opens up opportunities for us to iterate formats and develop other types of indexes.

Inverted index data with the format proposed in this RFC will be placed in Puffin as a blob, and will be assigned the type greptime-inverted-index-v1.

When there is a need for a geospatial index, we can design a new format in the same file and assign a new type like greptime-geospatial-index-v1.

killme2008
killme2008 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Nov 6, 2023
@killme2008
Copy link
Contributor

Cool, let's make it work.

Merged via the queue into GreptimeTeam:develop with commit 51ddebd Nov 6, 2023
10 checks passed
@zhongzc zhongzc deleted the zhongzc/rfc-inverted-index branch November 30, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia left review comments

@killme2008 killme2008 killme2008 approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r

@evenyag evenyag Awaiting requested review from evenyag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhongzc @killme2008 @fengjiachun @waynexia