-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor region lease keeper #2704
Conversation
8682bd0
to
7e1b273
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2704 +/- ##
===========================================
- Coverage 85.16% 84.83% -0.33%
===========================================
Files 763 763
Lines 122831 123311 +480
===========================================
+ Hits 104613 104615 +2
- Misses 18218 18696 +478 |
7e1b273
to
99aa8d6
Compare
@fengjiachun PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
I realized we can't simply retain active leader regions and also need to find out the downgraded leader regions.
find_staled_leader_regions
; now, it can find out the downgraded leader regions.find_staled_follower_regions
, returning upgradable and closable regions.Checklist
Refer to a related PR or issue link (optional)
#2700