Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: multiple licenses fixes #2714

Merged
merged 4 commits into from Nov 9, 2023
Merged

chore: multiple licenses fixes #2714

merged 4 commits into from Nov 9, 2023

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Nov 9, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Comments inline.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
LICENSE Show resolved Hide resolved
licenserc.toml Show resolved Hide resolved
licenserc.toml Show resolved Hide resolved
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2714 (a3be098) into develop (b9a7c2d) will decrease coverage by 0.44%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2714      +/-   ##
===========================================
- Coverage    85.22%   84.78%   -0.44%     
===========================================
  Files          765      765              
  Lines       123909   123911       +2     
===========================================
- Hits        105603   105063     -540     
- Misses       18306    18848     +542     

.github/workflows/license.yaml Show resolved Hide resolved
licenserc.toml Show resolved Hide resolved
Signed-off-by: tison <wander4096@gmail.com>
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tisonkun

@MichaelScofield MichaelScofield added this pull request to the merge queue Nov 9, 2023
Merged via the queue into GreptimeTeam:develop with commit 0cd6dac Nov 9, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants