Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grant lease to opening regions #2752

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Nov 15, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. add OpeningRegionKeeper
  2. grant lease to opening regions

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2700

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #2752 (dc71191) into develop (9bd1013) will decrease coverage by 0.42%.
The diff coverage is 96.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2752      +/-   ##
===========================================
- Coverage    85.46%   85.05%   -0.42%     
===========================================
  Files          772      772              
  Lines       125283   125406     +123     
===========================================
- Hits        107069   106658     -411     
- Misses       18214    18748     +534     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Nov 17, 2023
Merged via the queue into GreptimeTeam:develop with commit b28af94 Nov 17, 2023
14 checks passed
@WenyXu WenyXu self-assigned this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants