Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty by in range query #2770

Merged
merged 2 commits into from Nov 17, 2023
Merged

fix: empty by in range query #2770

merged 2 commits into from Nov 17, 2023

Conversation

Taylor-lagrange
Copy link
Contributor

@Taylor-lagrange Taylor-lagrange commented Nov 17, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix error when table no primary key and by not used

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

closes #2769

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #2770 (fb23173) into develop (ac4b6cd) will decrease coverage by 0.33%.
Report is 1 commits behind head on develop.
The diff coverage is 83.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2770      +/-   ##
===========================================
- Coverage    85.45%   85.12%   -0.33%     
===========================================
  Files          777      777              
  Lines       126497   125919     -578     
===========================================
- Hits        108095   107189     -906     
- Misses       18402    18730     +328     

src/query/src/range_select/plan_rewrite.rs Outdated Show resolved Hide resolved
tests/cases/standalone/common/range/by.sql Outdated Show resolved Hide resolved
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Nov 17, 2023
Merged via the queue into GreptimeTeam:develop with commit 91820a8 Nov 17, 2023
12 checks passed
@Taylor-lagrange Taylor-lagrange deleted the fix-range-query-crash branch November 18, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index out of bounds while executing range query
3 participants