Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align linear_regression to PromQL's behavior #2879

Merged
merged 3 commits into from Dec 8, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Dec 6, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Fix required input param type of predict_linear
  • Fix wrong operator priority
  • Fix wrong param to linear_regression

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #2879 (34c603c) into develop (b3ffe5c) will decrease coverage by 0.54%.
Report is 3 commits behind head on develop.
The diff coverage is 96.22%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2879      +/-   ##
===========================================
- Coverage    84.86%   84.33%   -0.54%     
===========================================
  Files          745      749       +4     
  Lines       117222   117939     +717     
===========================================
- Hits         99482    99465      -17     
- Misses       17740    18474     +734     

@waynexia waynexia added this pull request to the merge queue Dec 8, 2023
Merged via the queue into GreptimeTeam:develop with commit 58183fe Dec 8, 2023
13 checks passed
@waynexia waynexia deleted the enhance-promql branch December 8, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants