New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add build() function to return the database build info #2919
feat: add build() function to return the database build info #2919
Conversation
build() function to return the database build info GreptimeTeam#2909
I am wondering should we put |
Can you also add some corresponding sqlness cases? It's our integration test framework. And since the build info is changing, you may need this interceptor to fix the output result. |
Sure |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2919 +/- ##
===========================================
- Coverage 85.11% 84.59% -0.52%
===========================================
Files 756 752 -4
Lines 119511 119317 -194
===========================================
- Hits 101719 100937 -782
- Misses 17792 18380 +588 |
Good question! I think we can refactor them later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
cbcc153
to
73aeb1e
Compare
@Dysprosium0626 Have some code format issues and cargo-clippy warnings. You can format the code by Find all warnings by |
d462398
to
048bc31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-authored-by: Weny Xu <wenymedia@gmail.com>
BTW, there is a shortcut; just |
build() function to return the database build info #2909
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add
build
that returns the database build info looks like this:Checklist
Refer to a related PR or issue link (optional)
Related issue #2909