Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicate information_schema #2979

Merged
merged 3 commits into from
Dec 22, 2023
Merged

fix: duplicate information_schema #2979

merged 3 commits into from
Dec 22, 2023

Conversation

killme2008
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fixed #2976

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@killme2008 killme2008 marked this pull request as ready for review December 22, 2023 07:42
@killme2008 killme2008 added the docs-not-required This change does not impact docs. label Dec 22, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 22, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43f01cc) 85.90% compared to head (ccdeb7d) 85.31%.
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2979      +/-   ##
===========================================
- Coverage    85.90%   85.31%   -0.60%     
===========================================
  Files          780      780              
  Lines       125900   126172     +272     
===========================================
- Hits        108157   107639     -518     
- Misses       17743    18533     +790

waynexia
waynexia approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/cases/standalone/common/system/information_schema.sql Outdated Show resolved Hide resolved
@killme2008 killme2008 added this pull request to the merge queue Dec 22, 2023
Merged via the queue into GreptimeTeam:develop with commit d7b2e79 Dec 22, 2023
13 checks passed
@killme2008 killme2008 deleted the feature/funcs-information-schema branch December 22, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunng87 sunng87 sunng87 approved these changes

@waynexia waynexia waynexia approved these changes

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate information_schema
3 participants
@killme2008 @sunng87 @waynexia