Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add information_schema.files #3054

Merged
merged 3 commits into from Dec 31, 2023

Conversation

dimbtp
Copy link
Contributor

@dimbtp dimbtp commented Dec 29, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • add information_schema.files table

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2931

@github-actions github-actions bot added Doc not needed This PR do not impact docs Size: S labels Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41e51d4) 85.40% compared to head (970759f) 84.92%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3054      +/-   ##
==========================================
- Coverage   85.40%   84.92%   -0.49%     
==========================================
  Files         795      799       +4     
  Lines      128717   129074     +357     
==========================================
- Hits       109935   109617     -318     
- Misses      18782    19457     +675     

@killme2008
Copy link
Contributor

@dimbtp Thanks for your contribution. Could you run the sqlness by cargo run --bin sqlness-runner to update the tests/cases/standalone/common/system/information_schema.result and commit it too?

@github-actions github-actions bot added Size: M and removed Size: S labels Dec 29, 2023
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. A little question about extra field. Almost LGTM.

src/catalog/src/information_schema/memory_table/tables.rs Outdated Show resolved Hide resolved
@niebayes niebayes added this pull request to the merge queue Dec 31, 2023
@niebayes niebayes removed this pull request from the merge queue due to a manual request Dec 31, 2023
@killme2008 killme2008 added this pull request to the merge queue Dec 31, 2023
Merged via the queue into GreptimeTeam:main with commit 6070e88 Dec 31, 2023
16 checks passed
@dimbtp dimbtp deleted the feature/information-schema-files branch December 31, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc not needed This PR do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants