chore: impl KvBackend for MetaPeerClient #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyang24
changed the title
lyang24
force-pushed
the
kvbackend4metaclient
branch
from
e9d9f57
to
8f1a948
Compare
github-actions
bot
added
docs-not-required
lyang24
force-pushed
the
kvbackend4metaclient
branch
from
8f1a948
to
f41ad80
Compare
lyang24
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3076 +/- ##
==========================================
- Coverage 85.58% 85.00% -0.59%
==========================================
Files 805 818 +13
Lines 130658 133901 +3243
==========================================
+ Hits 111822 113820 +1998
- Misses 18836 20081 +1245 |
fengys1996
approved these changes
Jan 9, 2024
lyang24
force-pushed
the
kvbackend4metaclient
branch
from
f41ad80
to
0c24374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr intended to implement KvBackend trait for MetaPeerClient.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
This pr fixes the todo lefted in #3046
This pr does a few things:
KvBackendtrait impl.TxnServiceforMetaPeerClientas prerequisite forKvBackendtrait.KvBackendtrait's default get impl.MetaPeerClientdoes not support mutable method (i.e. put, delete) it will return unsupported error when these methods get called. Please note the status code of the unsupported error is actually 1003 internal instead of 1001 as documented in the public api.Checklist
Refer to a related PR or issue link (optional)