Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop exposing num_partitions #3132

Merged

Conversation

niebayes
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Since we only utilize the partition 0 (the first partition) of each Kafka topic, there's no need to expose the num_partitions to users through config file. If it's exposed, some users may set it to be greater than 1 and expect that there're multiple partitions per topic which we cannot provide.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. size/xs labels Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (490312b) 85.55% compared to head (7c8f48d) 85.04%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3132      +/-   ##
==========================================
- Coverage   85.55%   85.04%   -0.51%     
==========================================
  Files         818      819       +1     
  Lines      133858   134018     +160     
==========================================
- Hits       114521   113976     -545     
- Misses      19337    20042     +705     

@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 10, 2024
Merged via the queue into GreptimeTeam:main with commit 1b0e39a Jan 10, 2024
22 checks passed
@niebayes niebayes deleted the chore/stop_expose_num_partitions branch January 10, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants